-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 2021 Aerials Screensavers and fix reported bugs #51
Conversation
@@ -1,5 +1,3 @@ | |||
[![Codacy Badge](https://api.codacy.com/project/badge/Grade/e5d8dc168cf940a385d1a47837fe7596)](https://www.codacy.com/app/92enen/screensaver.atv4?utm_source=github.com&utm_medium=referral&utm_content=enen92/screensaver.atv4&utm_campaign=Badge_Grade) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This link was no longer working, I'm not familiar with Codacy but it gave me a 404 when I tried to go here.
@kubedzero - Trying your PR now, seems to be working (downloaded 25 new vids) bring the total to 273. Interestingly, I could not apply this PR directly to v3.0.2 because that tarball lacks I think it's due to https://github.com/enen92/screensaver.atv4/blob/master/.gitattributes#L9 @enen92 - Do you want to remove that line? |
@graysky2 that line is important since the file is not to be pushed to the repo when archiving the add-on. I'll tag a new release shortly, thanks very much @kubedzero |
Hope all is well and happy new year 🎉
assets
array, theinitialAssetCount
key, and theversion
key. The new version has acategories
arraypointsOfInterest
,accessibilityLabel
,id
,clipNumber
url-1080-HDR
,url-1080-SDR
,url-4K-SDR
,url-4K-HDR
,url-1080-H264
. Now there is acategories
array and ashotID
, and theclipNumber
is no longer used. They seem to differentiate based on shotID and ID alone now, with the accessibilityLabel being the same between themI took these changes and merged them into the local
entries.json
file, and also updated the URL to point at the latest version of the Resources tarball. Along with this, I updated the toggle settings to cover missing locations (and the new locations) and added a big block of translations for all three languages as well.I also checked the issues folder:
Testing
entrychecksumgenerator.py 2
to confirm the resources.tar file can still be downloaded from Apple, and that the entries.json can be retrieved from inside itentrychecksumgenerator.py 1
to test downloading all videos. I validated that the MD5s matched from the originalchecksums.json
from 2021, so any pre-existing URLs have been validated to retrieve the exact same content as before.